From e8572c523999944b3fe66d24640110e660bc593e Mon Sep 17 00:00:00 2001
From: Maik Stohn <marlin@stohn.de>
Date: Tue, 28 May 2013 15:53:07 +0200
Subject: [PATCH] Fix: Long menu entries (>14 or >18 chars) caused overrun in
hitachi display implementation
---
Marlin/ultralcd_implementation_hitachi_HD44780.h | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/Marlin/ultralcd_implementation_hitachi_HD44780.h b/Marlin/ultralcd_implementation_hitachi_HD44780.h
index d4e9967414..2cf33d930b 100644
--- a/Marlin/ultralcd_implementation_hitachi_HD44780.h
+++ b/Marlin/ultralcd_implementation_hitachi_HD44780.h
@@ -503,7 +503,7 @@ static void lcd_implementation_drawmenu_generic(uint8_t row, const char* pstr, c
#endif
lcd.setCursor(0, row);
lcd.print(pre_char);
- while((c = pgm_read_byte(pstr)) != '\0')
+ while( ((c = pgm_read_byte(pstr)) != '\0') && (n>0) )
{
lcd.print(c);
pstr++;
@@ -525,7 +525,7 @@ static void lcd_implementation_drawmenu_setting_edit_generic(uint8_t row, const
#endif
lcd.setCursor(0, row);
lcd.print(pre_char);
- while((c = pgm_read_byte(pstr)) != '\0')
+ while( ((c = pgm_read_byte(pstr)) != '\0') && (n>0) )
{
lcd.print(c);
pstr++;
@@ -547,7 +547,7 @@ static void lcd_implementation_drawmenu_setting_edit_generic_P(uint8_t row, cons
#endif
lcd.setCursor(0, row);
lcd.print(pre_char);
- while((c = pgm_read_byte(pstr)) != '\0')
+ while( ((c = pgm_read_byte(pstr)) != '\0') && (n>0) )
{
lcd.print(c);
pstr++;
@@ -617,7 +617,7 @@ static void lcd_implementation_drawmenu_sdfile_selected(uint8_t row, const char*
filename = longFilename;
longFilename[LCD_WIDTH-1] = '\0';
}
- while((c = *filename) != '\0')
+ while( ((c = *filename) != '\0') && (n>0) )
{
lcd.print(c);
filename++;
@@ -637,7 +637,7 @@ static void lcd_implementation_drawmenu_sdfile(uint8_t row, const char* pstr, co
filename = longFilename;
longFilename[LCD_WIDTH-1] = '\0';
}
- while((c = *filename) != '\0')
+ while( ((c = *filename) != '\0') && (n>0) )
{
lcd.print(c);
filename++;
@@ -658,7 +658,7 @@ static void lcd_implementation_drawmenu_sddirectory_selected(uint8_t row, const
filename = longFilename;
longFilename[LCD_WIDTH-2] = '\0';
}
- while((c = *filename) != '\0')
+ while( ((c = *filename) != '\0') && (n>0) )
{
lcd.print(c);
filename++;
@@ -679,7 +679,7 @@ static void lcd_implementation_drawmenu_sddirectory(uint8_t row, const char* pst
filename = longFilename;
longFilename[LCD_WIDTH-2] = '\0';
}
- while((c = *filename) != '\0')
+ while( ((c = *filename) != '\0') && (n>0) )
{
lcd.print(c);
filename++;