Default active low for TMC2130 DIAG1 (#10294)
- Added sanity check to inform users to set the endstop to inverting when using SENSORLESS_HOMING
This commit is contained in:
		
				
					committed by
					
						
						Scott Lahteine
					
				
			
			
				
	
			
			
			
						parent
						
							e8e60263c8
						
					
				
				
					commit
					75037493fa
				
			@@ -1457,12 +1457,22 @@ static_assert(X_MAX_LENGTH >= X_BED_SIZE && Y_MAX_LENGTH >= Y_BED_SIZE,
 | 
				
			|||||||
    #error "E4_CS_PIN is required for E4_IS_TMC2130. Define E4_CS_PIN in Configuration_adv.h."
 | 
					    #error "E4_CS_PIN is required for E4_IS_TMC2130. Define E4_CS_PIN in Configuration_adv.h."
 | 
				
			||||||
  #endif
 | 
					  #endif
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					  #if ENABLED(SENSORLESS_HOMING)
 | 
				
			||||||
    // Require STEALTHCHOP for SENSORLESS_HOMING on DELTA as the transition from spreadCycle to stealthChop
 | 
					    // Require STEALTHCHOP for SENSORLESS_HOMING on DELTA as the transition from spreadCycle to stealthChop
 | 
				
			||||||
    // is necessary in order to reset the stallGuard indication between the initial movement of all three
 | 
					    // is necessary in order to reset the stallGuard indication between the initial movement of all three
 | 
				
			||||||
    // towers to +Z and the individual homing of each tower. This restriction can be removed once a means of
 | 
					    // towers to +Z and the individual homing of each tower. This restriction can be removed once a means of
 | 
				
			||||||
    // clearing the stallGuard activated status is found.
 | 
					    // clearing the stallGuard activated status is found.
 | 
				
			||||||
  #if ENABLED(SENSORLESS_HOMING) && ENABLED(DELTA) && !ENABLED(STEALTHCHOP)
 | 
					    #if ENABLED(DELTA) && !ENABLED(STEALTHCHOP)
 | 
				
			||||||
      #error "SENSORLESS_HOMING on DELTA currently requires STEALTHCHOP."
 | 
					      #error "SENSORLESS_HOMING on DELTA currently requires STEALTHCHOP."
 | 
				
			||||||
 | 
					    #elif X_HOME_DIR == -1 && DISABLED(X_MIN_ENDSTOP_INVERTING)
 | 
				
			||||||
 | 
					      #error "SENSORLESS_HOMING requires X_MIN_ENDSTOP_INVERTING when homing to X_MIN."
 | 
				
			||||||
 | 
					    #elif X_HOME_DIR ==  1 && DISABLED(X_MAX_ENDSTOP_INVERTING)
 | 
				
			||||||
 | 
					      #error "SENSORLESS_HOMING requires X_MAX_ENDSTOP_INVERTING when homing to X_MAX."
 | 
				
			||||||
 | 
					    #elif Y_HOME_DIR == -1 && DISABLED(Y_MIN_ENDSTOP_INVERTING)
 | 
				
			||||||
 | 
					      #error "SENSORLESS_HOMING requires Y_MIN_ENDSTOP_INVERTING when homing to Y_MIN."
 | 
				
			||||||
 | 
					    #elif Y_HOME_DIR ==  1 && DISABLED(Y_MAX_ENDSTOP_INVERTING)
 | 
				
			||||||
 | 
					      #error "SENSORLESS_HOMING requires Y_MAX_ENDSTOP_INVERTING when homing to Y_MAX."
 | 
				
			||||||
 | 
					    #endif
 | 
				
			||||||
  #endif
 | 
					  #endif
 | 
				
			||||||
 | 
					
 | 
				
			||||||
  // Sensorless homing is required for both combined steppers in an H-bot
 | 
					  // Sensorless homing is required for both combined steppers in an H-bot
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -193,7 +193,6 @@
 | 
				
			|||||||
    st.power_down_delay(128); // ~2s until driver lowers to hold current
 | 
					    st.power_down_delay(128); // ~2s until driver lowers to hold current
 | 
				
			||||||
    st.hysteresis_start(3);
 | 
					    st.hysteresis_start(3);
 | 
				
			||||||
    st.hysteresis_end(2);
 | 
					    st.hysteresis_end(2);
 | 
				
			||||||
    st.diag1_active_high(1); // For sensorless homing
 | 
					 | 
				
			||||||
    #if ENABLED(STEALTHCHOP)
 | 
					    #if ENABLED(STEALTHCHOP)
 | 
				
			||||||
      st.stealth_freq(1); // f_pwm = 2/683 f_clk
 | 
					      st.stealth_freq(1); // f_pwm = 2/683 f_clk
 | 
				
			||||||
      st.stealth_autoscale(1);
 | 
					      st.stealth_autoscale(1);
 | 
				
			||||||
 
 | 
				
			|||||||
		Reference in New Issue
	
	Block a user