Rotary encoder cleanup (#20753)

This commit is contained in:
Scott Lahteine
2021-01-12 20:43:52 -06:00
committed by GitHub
parent 2b928b4754
commit 4a89731025
30 changed files with 484 additions and 438 deletions

View File

@ -459,10 +459,10 @@
#if !IS_NEWPANEL
// Buttons attached to a shift register
// Not wired yet
//#define SHIFT_CLK 38
//#define SHIFT_LD 42
//#define SHIFT_OUT 40
//#define SHIFT_EN 17
//#define SHIFT_CLK_PIN 38
//#define SHIFT_LD_PIN 42
//#define SHIFT_OUT_PIN 40
//#define SHIFT_EN_PIN 17
#endif
#endif
@ -608,9 +608,9 @@
// Buttons are directly attached to AUX-2
#if IS_RRW_KEYPAD
#define SHIFT_OUT 40
#define SHIFT_CLK 44
#define SHIFT_LD 42
#define SHIFT_OUT_PIN 40
#define SHIFT_CLK_PIN 44
#define SHIFT_LD_PIN 42
#define BTN_EN1 64
#define BTN_EN2 59
#define BTN_ENC 63

View File

@ -354,15 +354,15 @@
#if IS_NEWPANEL
#if IS_RRW_KEYPAD
#define SHIFT_OUT P0_18 // (51) (MOSI) J3-10 & AUX-3
#define SHIFT_CLK P0_15 // (52) (SCK) J3-9 & AUX-3
#define SHIFT_LD P1_31 // (49) J3-1 & AUX-3 (NOT 5V tolerant)
#define SHIFT_OUT_PIN P0_18 // (51) (MOSI) J3-10 & AUX-3
#define SHIFT_CLK_PIN P0_15 // (52) (SCK) J3-9 & AUX-3
#define SHIFT_LD_PIN P1_31 // (49) J3-1 & AUX-3 (NOT 5V tolerant)
#endif
#else
//#define SHIFT_CLK P3_26 // (31) J3-2 & AUX-4
//#define SHIFT_LD P3_25 // (33) J3-4 & AUX-4
//#define SHIFT_OUT P2_11 // (35) J3-3 & AUX-4
//#define SHIFT_EN P1_22 // (41) J5-4 & AUX-4
//#define SHIFT_CLK_PIN P3_26 // (31) J3-2 & AUX-4
//#define SHIFT_LD_PIN P3_25 // (33) J3-4 & AUX-4
//#define SHIFT_OUT_PIN P2_11 // (35) J3-3 & AUX-4
//#define SHIFT_EN_PIN P1_22 // (41) J5-4 & AUX-4
#endif
#if ANY(VIKI2, miniVIKI)

View File

@ -147,14 +147,14 @@
#define DOGLCD_A0 P2_06 // (59) J3-8 & AUX-2
#if IS_RRW_KEYPAD
#define SHIFT_OUT P0_18 // (51) (MOSI) J3-10 & AUX-3
#define SHIFT_CLK P0_15 // (52) (SCK) J3-9 & AUX-3
#define SHIFT_LD P1_31 // (49) not 5V tolerant J3-1 & AUX-3
#define SHIFT_OUT_PIN P0_18 // (51) (MOSI) J3-10 & AUX-3
#define SHIFT_CLK_PIN P0_15 // (52) (SCK) J3-9 & AUX-3
#define SHIFT_LD_PIN P1_31 // (49) not 5V tolerant J3-1 & AUX-3
#elif !IS_NEWPANEL
//#define SHIFT_OUT P2_11 // (35) J3-3 & AUX-4
//#define SHIFT_CLK P3_26 // (31) J3-2 & AUX-4
//#define SHIFT_LD P3_25 // (33) J3-4 & AUX-4
//#define SHIFT_EN P1_22 // (41) J5-4 & AUX-4
//#define SHIFT_OUT_PIN P2_11 // (35) J3-3 & AUX-4
//#define SHIFT_CLK_PIN P3_26 // (31) J3-2 & AUX-4
//#define SHIFT_LD_PIN P3_25 // (33) J3-4 & AUX-4
//#define SHIFT_EN_PIN P1_22 // (41) J5-4 & AUX-4
#endif
#if ANY(VIKI2, miniVIKI)

View File

@ -149,9 +149,9 @@
#define BTN_ENC 27
// Hardware buttons for manual movement of XYZ
#define SHIFT_OUT 19
#define SHIFT_LD 18
#define SHIFT_CLK 17
#define SHIFT_OUT_PIN 19
#define SHIFT_LD_PIN 18
#define SHIFT_CLK_PIN 17
//#define UI1 31
//#define UI2 22

View File

@ -156,9 +156,9 @@
#define BTN_ENC 38
// Hardware buttons for manual movement of XYZ
#define SHIFT_OUT 42
#define SHIFT_LD 41
#define SHIFT_CLK 40
#define SHIFT_OUT_PIN 42
#define SHIFT_LD_PIN 41
#define SHIFT_CLK_PIN 40
//#define UI1 43
//#define UI2 37

View File

@ -146,10 +146,10 @@
#else // !IS_NEWPANEL
#define SHIFT_CLK 38
#define SHIFT_LD 42
#define SHIFT_OUT 40
#define SHIFT_EN 17
#define SHIFT_CLK_PIN 38
#define SHIFT_LD_PIN 42
#define SHIFT_OUT_PIN 40
#define SHIFT_EN_PIN 17
#define LCD_PINS_RS 16
#define LCD_PINS_ENABLE 5

View File

@ -156,10 +156,10 @@
#else
// Buttons attached to a shift register
#define SHIFT_CLK 38
#define SHIFT_LD 42
#define SHIFT_OUT 40
#define SHIFT_EN 17
#define SHIFT_CLK_PIN 38
#define SHIFT_LD_PIN 42
#define SHIFT_OUT_PIN 40
#define SHIFT_EN_PIN 17
#define LCD_PINS_RS 16
#define LCD_PINS_ENABLE 5

View File

@ -146,10 +146,10 @@
#define BTN_ENC 43
#else
// Buttons attached to shift register of reprapworld keypad v1.1
#define SHIFT_CLK 63
#define SHIFT_LD 42
#define SHIFT_OUT 17
#define SHIFT_EN 17
#define SHIFT_CLK_PIN 63
#define SHIFT_LD_PIN 42
#define SHIFT_OUT_PIN 17
#define SHIFT_EN_PIN 17
#endif
#endif // HAS_WIRED_LCD

View File

@ -162,10 +162,10 @@
#define LCD_PINS_D6 39
#define LCD_PINS_D7 15
#define SHIFT_CLK 43
#define SHIFT_LD 35
#define SHIFT_OUT 34
#define SHIFT_EN 44
#define SHIFT_CLK_PIN 43
#define SHIFT_LD_PIN 35
#define SHIFT_OUT_PIN 34
#define SHIFT_EN_PIN 44
#if MB(MEGATRONICS_31, MEGATRONICS_32)
#define SD_DETECT_PIN 56

View File

@ -833,17 +833,17 @@
#if PIN_EXISTS(SERVO3)
REPORT_NAME_DIGITAL(__LINE__, SERVO3_PIN)
#endif
#if defined(SHIFT_CLK) && SHIFT_CLK >= 0
REPORT_NAME_DIGITAL(__LINE__, SHIFT_CLK)
#if PIN_EXISTS(SHIFT_CLK)
REPORT_NAME_DIGITAL(__LINE__, SHIFT_CLK_PIN)
#endif
#if defined(SHIFT_EN) && SHIFT_EN >= 0
REPORT_NAME_DIGITAL(__LINE__, SHIFT_EN)
#if PIN_EXISTS(SHIFT_EN)
REPORT_NAME_DIGITAL(__LINE__, SHIFT_EN_PIN)
#endif
#if defined(SHIFT_LD) && SHIFT_LD >= 0
REPORT_NAME_DIGITAL(__LINE__, SHIFT_LD)
#if PIN_EXISTS(SHIFT_LD)
REPORT_NAME_DIGITAL(__LINE__, SHIFT_LD_PIN)
#endif
#if defined(SHIFT_OUT) && SHIFT_OUT >= 0
REPORT_NAME_DIGITAL(__LINE__, SHIFT_OUT)
#if PIN_EXISTS(SHIFT_OUT)
REPORT_NAME_DIGITAL(__LINE__, SHIFT_OUT_PIN)
#endif
#if PIN_EXISTS(SLED)
REPORT_NAME_DIGITAL(__LINE__, SLED_PIN)

View File

@ -239,10 +239,10 @@
// Buttons attached to a shift register
// Not wired yet
//#define SHIFT_CLK 38
//#define SHIFT_LD 42
//#define SHIFT_OUT 40
//#define SHIFT_EN 17
//#define SHIFT_CLK_PIN 38
//#define SHIFT_LD_PIN 42
//#define SHIFT_OUT_PIN 40
//#define SHIFT_EN_PIN 17
#define LCD_PINS_RS 75
#define LCD_PINS_ENABLE 17

View File

@ -504,10 +504,10 @@
#if !IS_NEWPANEL
// Buttons attached to a shift register
// Not wired yet
//#define SHIFT_CLK 38
//#define SHIFT_LD 42
//#define SHIFT_OUT 40
//#define SHIFT_EN 17
//#define SHIFT_CLK_PIN 38
//#define SHIFT_LD_PIN 42
//#define SHIFT_OUT_PIN 40
//#define SHIFT_EN_PIN 17
#endif
#endif
@ -722,9 +722,9 @@
#endif // HAS_WIRED_LCD
#if IS_RRW_KEYPAD && !HAS_ADC_BUTTONS
#define SHIFT_OUT 40
#define SHIFT_CLK 44
#define SHIFT_LD 42
#define SHIFT_OUT_PIN 40
#define SHIFT_CLK_PIN 44
#define SHIFT_LD_PIN 42
#ifndef BTN_EN1
#define BTN_EN1 64
#endif

View File

@ -342,10 +342,10 @@
#if !IS_NEWPANEL
// Buttons attached to a shift register
// Not wired yet
//#define SHIFT_CLK 38
//#define SHIFT_LD 42
//#define SHIFT_OUT 40
//#define SHIFT_EN 17
//#define SHIFT_CLK_PIN 38
//#define SHIFT_LD_PIN 42
//#define SHIFT_OUT_PIN 40
//#define SHIFT_EN_PIN 17
#endif
#endif
@ -491,9 +491,9 @@
// Buttons are directly attached to AUX-2
#if IS_RRW_KEYPAD
#define SHIFT_OUT 40
#define SHIFT_CLK 44
#define SHIFT_LD 42
#define SHIFT_OUT_PIN 40
#define SHIFT_CLK_PIN 44
#define SHIFT_LD_PIN 42
#define BTN_EN1 64
#define BTN_EN2 59
#define BTN_ENC 63

View File

@ -142,10 +142,10 @@
#else // !IS_NEWPANEL - Old style panel with shift register
// Buttons attached to a shift register
#define SHIFT_CLK 38
#define SHIFT_LD 42
#define SHIFT_OUT 40
#define SHIFT_EN 17
#define SHIFT_CLK_PIN 38
#define SHIFT_LD_PIN 42
#define SHIFT_OUT_PIN 40
#define SHIFT_EN_PIN 17
#define LCD_PINS_RS 16
#define LCD_PINS_ENABLE 5

View File

@ -197,10 +197,10 @@
#else // !IS_NEWPANEL - Old style panel with shift register
// Buttons attached to a shift register
#define SHIFT_CLK 38
#define SHIFT_LD 42
#define SHIFT_OUT 40
#define SHIFT_EN 17
#define SHIFT_CLK_PIN 38
#define SHIFT_LD_PIN 42
#define SHIFT_OUT_PIN 40
#define SHIFT_EN_PIN 17
#define LCD_PINS_RS 16
#define LCD_PINS_ENABLE 5

View File

@ -69,9 +69,9 @@
#undef ADC_KEYPAD_PIN
#undef BEEPER_PIN
#undef SHIFT_OUT
#undef SHIFT_CLK
#undef SHIFT_LD
#undef SHIFT_OUT_PIN
#undef SHIFT_CLK_PIN
#undef SHIFT_LD_PIN
#undef BTN_EN1
#undef BTN_EN2
#undef BTN_ENC

View File

@ -363,10 +363,10 @@
#if !IS_NEWPANEL
// Buttons attached to a shift register
// Not wired yet
//#define SHIFT_CLK 38
//#define SHIFT_LD 42
//#define SHIFT_OUT 40
//#define SHIFT_EN 17
//#define SHIFT_CLK_PIN 38
//#define SHIFT_LD_PIN 42
//#define SHIFT_OUT_PIN 40
//#define SHIFT_EN_PIN 17
#endif
#endif
@ -567,9 +567,9 @@
// Buttons are directly attached to AUX-2
#if IS_RRW_KEYPAD
// TO TEST
//#define SHIFT_OUT 40
//#define SHIFT_CLK 44
//#define SHIFT_LD 42
//#define SHIFT_OUT_PIN 40
//#define SHIFT_CLK_PIN 44
//#define SHIFT_LD_PIN 42
//#define BTN_EN1 56 // Mega/Due:64 - AGCM4:56
//#define BTN_EN2 72 // Mega/Due:59 - AGCM4:72
//#define BTN_ENC 55 // Mega/Due:63 - AGCM4:55

View File

@ -146,10 +146,10 @@
#define BEEPER_PIN PC1 // 33
// Buttons attached to a shift register
// Not wired yet
//#define SHIFT_CLK PC6 // 38
//#define SHIFT_LD PC10 // 42
//#define SHIFT_OUT PC8 // 40
//#define SHIFT_EN PA1 // 17
//#define SHIFT_CLK_PIN PC6 // 38
//#define SHIFT_LD_PIN PC10 // 42
//#define SHIFT_OUT_PIN PC8 // 40
//#define SHIFT_EN_PIN PA1 // 17
#endif
#endif
@ -260,9 +260,9 @@
#define BTN_EN1 PE0 // 64
#define BTN_EN2 PD11 // 59
#define BTN_ENC PD15 // 63
#define SHIFT_OUT PC8 // 40
#define SHIFT_CLK PC12 // 44
#define SHIFT_LD PC10 // 42
#define SHIFT_OUT_PIN PC8 // 40
#define SHIFT_CLK_PIN PC12 // 44
#define SHIFT_LD_PIN PC10 // 42
#elif ENABLED(PANEL_ONE)
#define BTN_EN1 PD11 // 59 // AUX2 PIN 3
#define BTN_EN2 PD15 // 63 // AUX2 PIN 4

View File

@ -146,7 +146,7 @@
#endif
#if IS_RRW_KEYPAD
#define SHIFT_OUT 40
#define SHIFT_CLK 44
#define SHIFT_LD 42
#define SHIFT_OUT_PIN 40
#define SHIFT_CLK_PIN 44
#define SHIFT_LD_PIN 42
#endif