Tweak tests, consolidate pins target validation (#21254)

Marlin/src/pins/sam/env_validate.h

@@ -0,0 +1,33 @@
+/**
+ * Marlin 3D Printer Firmware
+ * Copyright (c) 2021 MarlinFirmware [https://github.com/MarlinFirmware/Marlin]
+ *
+ * Based on Sprinter and grbl.
+ * Copyright (c) 2011 Camiel Gubbels / Erik van der Zalm
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
+ */
+#pragma once
+
+#if BOTH(ALLOW_MEGA1280, ALLOW_MEGA2560) && NOT_TARGET(__SAM3X8E__, __AVR_ATmega1280__, __AVR_ATmega2560__)
+  #error "Oops! Select 'Arduino Due or Mega' in 'Tools > Board.'"
+#elif ENABLED(ALLOW_MEGA2560) && NOT_TARGET(__SAM3X8E__, __AVR_ATmega2560__)
+  #error "Oops! Select 'Arduino Due or Mega' in 'Tools > Board.'"
+#elif ENABLED(ALLOW_MEGA1280) && NOT_TARGET(__SAM3X8E__, __AVR_ATmega1280__)
+  #error "Oops! Select 'Arduino Due' in 'Tools > Board.'"
+#endif
+
+#undef ALLOW_MEGA1280
+#undef ALLOW_MEGA2560

Marlin/src/pins/sam/pins_ADSK.h

@@ -27,9 +27,9 @@
 
 #define BOARD_INFO_NAME "ADSK"
 
-#if NOT_TARGET(__SAM3X8E__, __AVR_ATmega1280__, __AVR_ATmega2560__)
-  #error "Oops! Select 'Arduino Due or Mega' in 'Tools > Board.'"
-#endif
+#define ALLOW_MEGA1280
+#define ALLOW_MEGA2560
+#include "env_validate.h"
 
 /* CNC shield modifications:
 FROM THE BOTTOM CUT THE 5V PIN THAT GOES TO ARDUINO!!!

Marlin/src/pins/sam/pins_ALLIGATOR_R2.h

@@ -26,9 +26,7 @@
  * https://reprap.org/wiki/Alligator_Board
  */
 
-#if NOT_TARGET(__SAM3X8E__)
-  #error "Oops! Select 'Arduino Due' in 'Tools > Board.'"
-#endif
+#include "env_validate.h"
 
 #define BOARD_INFO_NAME    "Alligator Board R2"
 

Marlin/src/pins/sam/pins_CNCONTROLS_15D.h

@@ -24,9 +24,7 @@
  * CNControls V15 for HMS434 with DUE pin assignments
  */
 
-#if NOT_TARGET(__SAM3X8E__)
-  #error "Oops! Select 'Arduino Due' in 'Tools > Board.'"
-#endif
+#include "env_validate.h"
 
 #define BOARD_INFO_NAME "CN Controls V15D"
 

Marlin/src/pins/sam/pins_DUE3DOM.h

@@ -25,9 +25,7 @@
  * DUE3DOM pin assignments
  */
 
-#if NOT_TARGET(__SAM3X8E__)
-  #error "Oops! Select 'Arduino Due' in 'Tools > Board.'"
-#endif
+#include "env_validate.h"
 
 #define BOARD_INFO_NAME "DUE3DOM"
 

Marlin/src/pins/sam/pins_DUE3DOM_MINI.h

@@ -25,9 +25,7 @@
  * DUE3DOM MINI pin assignments
  */
 
-#if NOT_TARGET(__SAM3X8E__)
-  #error "Oops! Select 'Arduino Due' in 'Tools > Board.'"
-#endif
+#include "env_validate.h"
 
 #define BOARD_INFO_NAME "DUE3DOM MINI"
 

Marlin/src/pins/sam/pins_PRINTRBOARD_G2.h

@@ -25,9 +25,7 @@
  * PRINTRBOARD_G2
  */
 
-#if NOT_TARGET(__SAM3X8E__)
-  #error "Oops! Select 'Arduino Due' in 'Tools > Board.'"
-#endif
+#include "env_validate.h"
 
 #ifndef BOARD_INFO_NAME
   #define BOARD_INFO_NAME "Printrboard G2"

Marlin/src/pins/sam/pins_RADDS.h

@@ -25,9 +25,7 @@
  * RADDS
  */
 
-#if NOT_TARGET(__SAM3X8E__)
-  #error "Oops! Select 'Arduino Due' in 'Tools > Board.'"
-#endif
+#include "env_validate.h"
 
 #define BOARD_INFO_NAME "RADDS"
 

Marlin/src/pins/sam/pins_RAMPS4DUE.h

@@ -39,14 +39,9 @@
  *       A15 | NC
  */
 
-#if NOT_TARGET(__SAM3X8E__, __AVR_ATmega2560__)
-  #error "Oops! Select 'Arduino Due' or 'Arduino/Genuino Mega or Mega 2560' in 'Tools > Board.'"
-#endif
-
+#define ALLOW_SAM3X8E
 #define BOARD_INFO_NAME "RAMPS4DUE"
 
-#define IS_RAMPS4DUE
-
 //
 // Temperature Sensors
 //

Marlin/src/pins/sam/pins_RAMPS_DUO.h

@@ -43,14 +43,9 @@
  *       A15 | A11
  */
 
-#if NOT_TARGET(__SAM3X8E__, __AVR_ATmega2560__)
-  #error "Oops! Select 'Arduino Due' or 'Arduino/Genuino Mega or Mega 2560' in 'Tools > Board.'"
-#endif
-
 #define BOARD_INFO_NAME "RAMPS Duo"
 
-#define IS_RAMPS_DUO
-
+#define ALLOW_SAM3X8E
 #include "../ramps/pins_RAMPS.h"
 
 //

Marlin/src/pins/sam/pins_RAMPS_FD_V1.h

@@ -28,9 +28,7 @@
  * Use 4k7 thermistor tables
  */
 
-#if NOT_TARGET(__SAM3X8E__)
-  #error "Oops! Select 'Arduino Due' in 'Tools > Board.'"
-#endif
+#include "env_validate.h"
 
 #ifndef BOARD_INFO_NAME
   #define BOARD_INFO_NAME "RAMPS-FD v1"

Marlin/src/pins/sam/pins_RAMPS_SMART.h

@@ -60,12 +60,8 @@
  * (Search the web for "Arduino DUE Board Pinout" to see the correct header.)
  */
 
-#if NOT_TARGET(__SAM3X8E__, __AVR_ATmega2560__)
-  #error "Oops! Select 'Arduino Due' or 'Mega 2560' in 'Tools > Board.'"
-#endif
-
 #define BOARD_INFO_NAME "RAMPS-SMART"
-#define IS_RAMPS_SMART
+#define ALLOW_SAM3X8E
 #include "../ramps/pins_RAMPS.h"
 
 // I2C EEPROM with 4K of space

Marlin/src/pins/sam/pins_RURAMPS4D_11.h

@@ -32,9 +32,7 @@
  *           |
  */
 
-#if NOT_TARGET(__SAM3X8E__)
-  #error "Oops! Select 'Arduino Due' in 'Tools > Board.'"
-#endif
+#include "env_validate.h"
 
 #define BOARD_INFO_NAME "RuRAMPS4Due v1.1"
 

Marlin/src/pins/sam/pins_RURAMPS4D_13.h

@@ -32,9 +32,7 @@
  *           |
  */
 
-#if NOT_TARGET(__SAM3X8E__)
-  #error "Oops! Select 'Arduino Due' in 'Tools > Board.'"
-#endif
+#include "env_validate.h"
 
 #define BOARD_INFO_NAME "RuRAMPS4Due v1.3"
 

Marlin/src/pins/sam/pins_ULTRATRONICS_PRO.h

@@ -26,9 +26,7 @@
  * https://reprapworld.com/documentation/datasheet_ultratronics10_05.pdf
  */
 
-#if NOT_TARGET(ARDUINO_ARCH_SAM)
-  #error "Oops! Select 'Arduino Due' in 'Tools > Board.'"
-#endif
+#include "env_validate.h"
 
 #define BOARD_INFO_NAME "Ultratronics v1.0"