bissen21/Marlin_Firmware
1
0
Fork 0
Code Issues Pull Requests Projects Releases 4 Wiki Activity

volatile_block_buffer_runtime_us

Browse Source 
`block_buffer_runtime_us` is mangled in the planner and in the stepper-ISR.
So it needs to be volatile and interrupt protected.
This commit is contained in:
AnHardt
2016-12-09 14:10:55 +01:00
parent 8383f35b40
commit 13eebd11cf
2 changed files with 17 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Marlin/planner.cpp
View File

@@ -146,7 +146,7 @@ float Planner::previous_speed[NUM_AXIS],
#endif #endif
#if ENABLED(ENSURE_SMOOTH_MOVES) #if ENABLED(ENSURE_SMOOTH_MOVES)
uint32_t Planner::block_buffer_runtime_us = 0; volatile uint32_t Planner::block_buffer_runtime_us = 0;
#endif #endif
/** /**
@@ -1007,7 +1007,9 @@ void Planner::_buffer_line(const float &a, const float &b, const float &c, const
segment_time = (MIN_BLOCK_TIME) * 1000UL; segment_time = (MIN_BLOCK_TIME) * 1000UL;
} }
block->segment_time = segment_time; block->segment_time = segment_time;
block_buffer_runtime_us += segment_time; CRITICAL_SECTION_START
block_buffer_runtime_us += segment_time;
CRITICAL_SECTION_END
#endif #endif
block->nominal_speed = block->millimeters * inverse_mm_s; // (mm/sec) Always > 0 block->nominal_speed = block->millimeters * inverse_mm_s; // (mm/sec) Always > 0

21
Marlin/planner.h
View File

@@ -215,7 +215,7 @@ class Planner {
#endif #endif
#if ENABLED(ENSURE_SMOOTH_MOVES) #if ENABLED(ENSURE_SMOOTH_MOVES)
static uint32_t block_buffer_runtime_us; //Theoretical block buffer runtime in µs volatile static uint32_t block_buffer_runtime_us; //Theoretical block buffer runtime in µs
#endif #endif
public: public:
@@ -387,21 +387,26 @@ class Planner {
SBI(block->flag, BLOCK_BIT_BUSY); SBI(block->flag, BLOCK_BIT_BUSY);
return block; return block;
} }
else else {
#if ENABLED(ENSURE_SMOOTH_MOVES)
clear_block_buffer_runtime(); // paranoia. Buffer is empty now - so reset accumulated time to zero.
#endif
return NULL; return NULL;
}
} }
#if ENABLED(ENSURE_SMOOTH_MOVES) #if ENABLED(ENSURE_SMOOTH_MOVES)
static bool long_move() { static bool long_move() {
if (block_buffer_runtime_us) { CRITICAL_SECTION_START
return block_buffer_runtime_us > (LCD_UPDATE_THRESHOLD) * 1000UL + (MIN_BLOCK_TIME) * 3000UL; uint32_t bbru = block_buffer_runtime_us;
} CRITICAL_SECTION_END
else return !bbru || bbru > (LCD_UPDATE_THRESHOLD) * 1000UL + (MIN_BLOCK_TIME) * 3000UL;
return true;
} }
static void clear_block_buffer_runtime(){ static void clear_block_buffer_runtime(){
block_buffer_runtime_us = 0; CRITICAL_SECTION_START
block_buffer_runtime_us = 0;
CRITICAL_SECTION_END
} }
#endif #endif